feat(logger-middleware): add support for color and pretty formatters #10862
+275
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
changed the title
MichaelDeBoey
changed the title
Member
|
Let's default to using color when we detect we are in a TTY. This is going to be tricky since we don't want to lose the ability to run logger middleware in browser/service worker environment. Something like this could work: const useColor = typeof process !== 'undefined' &&
process.stdout.isTTY &&
process.env.NO_COLOR == null
function colorize(text: string, color: string) {
return useColor ? `${color}${text}${reset}` : text
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds optional colorized output and human-readable formatters for durations and file sizes.
New features:
colorsoption for colorized output (off by default)formatDuration()- formats ms as "1.20s", "45ms", etc.formatFileSize()- formats bytes as "1.2 kB", "120 B", etc.%durationPrettyand%contentLengthPrettyColors (when enabled):
No breaking changes - colors default to off.